Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move measurement units to right model (d'oh!) #1214

Merged
merged 6 commits into from
Mar 28, 2024
Merged

fix: move measurement units to right model (d'oh!) #1214

merged 6 commits into from
Mar 28, 2024

Conversation

shrouxm
Copy link
Member

@shrouxm shrouxm commented Mar 27, 2024

Description

Needed for techmatters/terraso-client-shared#363. Also did #1212 and found a dormant bug on the way.

Checklist

  • Corresponding issue has been opened
  • New tests added

@shrouxm shrouxm requested a review from tm-ruxandra March 27, 2024 22:41
@paulschreiber paulschreiber self-requested a review March 27, 2024 23:30
paulschreiber
paulschreiber requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@paulschreiber paulschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing test(s).

@shrouxm shrouxm requested a review from paulschreiber March 27, 2024 23:39
@shrouxm shrouxm merged commit d50504f into main Mar 28, 2024
7 checks passed
@shrouxm shrouxm deleted the fix/measurement-units branch March 28, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulschreiber paulschreiber paulschreiber approved these changes

@tm-ruxandra tm-ruxandra Awaiting requested review from tm-ruxandra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrouxm @paulschreiber